[PATCH] D73595: [mlir][Linalg][doc] Add Design Document for the Linalg Dialect

[Diego Caballero via Phabricator via llvm-commits]

dcaballe added a comment.

Thanks for all this documentation! Very elucidating! Just a couple of minor comments on the code. Probably missing something on my side.



================
Comment at: mlir/docs/Dialects/Linalg.md:68
+              %B: memref<?xvector<4xf32, layout2>>) {
+  linalg.generic #attrs (%2, %3): memref<?xf32, layout1>,
+                                  memref<?xvector<4xf32, layout2>>
----------------
Are %2 and %3 actually %A and %B?


================
Comment at: mlir/docs/Dialects/Linalg.md:150
+  %I = "dim" %2, 1: index
+  %J2 = "dim" %3, 0: index
+  // iteration space is consistent with data + mapping inference 
----------------
Same re %2 and %3.

I'm probably missing something but shouldn't `%J2 = "dim" %3, 0: index` be `%J2 = "dim" %3, 1: index` 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73595/new/

https://reviews.llvm.org/D73595