[PATCH] D73030: GlobalISel: Assume G_INTRINSIC* are convergent

Aditya Nandakumar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 4 12:51:23 PST 2020


aditya_nandakumar added a comment.

In D73030#1857708 <https://reviews.llvm.org/D73030#1857708>, @aemerson wrote:

> I'm not 100% sure on what the convergent attribute means here, but assuming that it means it's not allowed to sink instructions into control flow etc, I don't think we should be marking these generic intrinsic ops with it. On arm64 we can use G_INTRINSIC to represent user-written intrinsic instructions which have no problem with being made control dependent.


My understanding with this patch was let's go with this (and be correct ie don't sink instructions so you don't break semantics) and if it ends up being a problem, we'll add another intrinsic opcode.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73030/new/

https://reviews.llvm.org/D73030





More information about the llvm-commits mailing list