[PATCH] D73480: [VectorCombine] new IR transform pass for partial vector ops

[Sanjay Patel via Phabricator via llvm-commits]

spatel marked an inline comment as done.
spatel added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/VectorCombine.cpp:56
+
+  // Check if the scalar alternative is cheaper. Extra uses of the extracts mean
+  // that we include those costs in the vector total because those instructions
----------------
lebedev.ri wrote:
> Word "alternative" usually means "something other than what currently is".
> Using it here seems misleading to me - currently we do have scalar comparison :)
Good point - the vector code is the alternative that we will compare to.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73480/new/

https://reviews.llvm.org/D73480