[PATCH] D73894: [MLIR] Add mapping based on ValueRange to BlockAndValueMapper.
River Riddle via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Feb 4 09:53:43 PST 2020
rriddle added a comment.
LGTM after fixing the format issue.
================
Comment at: mlir/include/mlir/IR/BlockAndValueMapping.h:37
+ std::enable_if_t<!std::is_assignable<Value, S>::value &&
+ !std::is_same<S, Block *>::value> * = nullptr>
+ void map(S&& from, T&& to) {
----------------
nit: Can you just use is_assignable for both?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73894/new/
https://reviews.llvm.org/D73894
More information about the llvm-commits
mailing list