[PATCH] D73972: [ARM] Correct missing newline after outputting .tlsdescseq directive.

David Spickett via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 4 09:17:27 PST 2020


DavidSpickett created this revision.
DavidSpickett added a reviewer: ostannard.
Herald added subscribers: llvm-commits, hiraditya, kristof.beyls.
Herald added a project: LLVM.
DavidSpickett added a parent revision: D73469: [ARM][AsmParser] Make assembly directives case insensitive.

Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D73972

Files:
  llvm/lib/Target/ARM/MCTargetDesc/ARMELFStreamer.cpp
  llvm/test/MC/ARM/directive-tlsdescseq.s


Index: llvm/test/MC/ARM/directive-tlsdescseq.s
===================================================================
--- llvm/test/MC/ARM/directive-tlsdescseq.s
+++ llvm/test/MC/ARM/directive-tlsdescseq.s
@@ -25,9 +25,9 @@
 
 @ CHECK-ASM: ldr r1, [pc, #8]
 @ CHECK-ASM: .tlsdescseq variable
-@ CHECK-ASM: add r2, pc, r1
+@ CHECK-ASM-NEXT: add r2, pc, r1
 @ CHECK-ASM: .tlsdescseq variable
-@ CHECK-ASM: ldr r3, [r1, #4]
+@ CHECK-ASM-NEXT: ldr r3, [r1, #4]
 @ CHECK-ASM: .tlsdescseq variable
-@ CHECK-ASM: blx r3
+@ CHECK-ASM-NEXT: blx r3
 
Index: llvm/lib/Target/ARM/MCTargetDesc/ARMELFStreamer.cpp
===================================================================
--- llvm/lib/Target/ARM/MCTargetDesc/ARMELFStreamer.cpp
+++ llvm/lib/Target/ARM/MCTargetDesc/ARMELFStreamer.cpp
@@ -238,7 +238,7 @@
 
 void
 ARMTargetAsmStreamer::AnnotateTLSDescriptorSequence(const MCSymbolRefExpr *S) {
-  OS << "\t.tlsdescseq\t" << S->getSymbol().getName();
+  OS << "\t.tlsdescseq\t" << S->getSymbol().getName() << "\n";
 }
 
 void ARMTargetAsmStreamer::emitThumbSet(MCSymbol *Symbol, const MCExpr *Value) {


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D73972.242351.patch
Type: text/x-patch
Size: 1093 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200204/073f8490/attachment.bin>


More information about the llvm-commits mailing list