[PATCH] D72973: using symbol index+symbol name + storage mapping class as label for llvm-objdump -D

[David Tenty via Phabricator via llvm-commits]

daltenty added inline comments.


================
Comment at: llvm/tools/llvm-objdump/llvm-objdump.cpp:1383
                          SectionAddr + Start + VMAAdjustment);
-
-      outs() << SymbolName << ":\n";
+      if (Obj->isXCOFF()) {
+        printXCOFFSymbolDescription(Symbols[SI], SymbolName);
----------------
Shouldn't this behaviour be option gated under an XCOFF specific option? As is this is going to result in output incompatible with binutils objdump on AIX, which could break tools.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72973/new/

https://reviews.llvm.org/D72973