[PATCH] D73815: AMDGPU: Fix divergence analysis of control flow intrinsics

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 4 08:04:10 PST 2020


arsenm added a comment.

In D73815#1857088 <https://reviews.llvm.org/D73815#1857088>, @alex-t wrote:

> I agree that current expensive walk on IR should be removed. 
>  I initially consider it as a temporary solution that allows to switch to the new concept 
>  of assignment correct register classes keeping in mind to eventually find another way to workaround CF results exceptions.
>
> What I conceptually don't like here is mixing the "divergence" and register class notions.
>  The mask produced by the CF intrinsics is always scalar - not same as always uniform.


Scalar is the only modeled concept of uniform we have. We don't currently try to model workgroup uniform, so these should be the same


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73815/new/

https://reviews.llvm.org/D73815





More information about the llvm-commits mailing list