[PATCH] D73579: [mlir] Add elementAttr to TypedArrayAttrBase.

Lei Zhang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 4 07:45:45 PST 2020


antiagainst added a comment.

In D73579#1852960 <https://reviews.llvm.org/D73579#1852960>, @mehdi_amini wrote:

> @antiagainst : what is the best way to test that?


Sorry for the late reply! Existing tests for TableGen are testing TableGen backends in tree. What @abeakkas has here is a field for an out-of-tree TableGen backend so I'm not sure that there is a good approach except for just dumping the record without invoking any backend and check the field is as expected.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73579/new/

https://reviews.llvm.org/D73579





More information about the llvm-commits mailing list