[PATCH] D73962: [DebugInfo] Error if unsupported address size detected in line table

[James Henderson via Phabricator via llvm-commits]

jhenderson marked an inline comment as done.
jhenderson added inline comments.


================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFDebugLine.cpp:635
           uint8_t ExtractorAddressSize = DebugLineData.getAddressSize();
-          if (ExtractorAddressSize != Len - 1 && ExtractorAddressSize != 0)
+          // FIXME: Check to make sure Len <= sizeof(uint8_t).
+          uint8_t OpcodeAddressSize = Len - 1;
----------------
ikudrin wrote:
> jhenderson wrote:
> > I'm going to write a follow-up patch for this issue.
> You probably meant `Len >= 1`, right?
I'm guessing this comment is related to the now-deleted FIXME?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73962/new/

https://reviews.llvm.org/D73962