[PATCH] D72154: [DebugInfo] Make debug line address size mismatch non-fatal to parsing

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 4 06:23:44 PST 2020


jhenderson marked an inline comment as done.
jhenderson added inline comments.


================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFDebugLine.cpp:621
+          // address size.
           DebugLineData.setAddressSize(Len - 1);
+          State.Row.Address.Address = DebugLineData.getRelocatedAddress(
----------------
jhenderson wrote:
> ikudrin wrote:
> > @jhenderson, it looks like that an incorrect `Len` value, i. e. not `1`, `2`, `4` or `8`, eventually leads to a crash in `DataExtractor::getUnsigned()`. Please add a patch to check that case.
> Will do!
Patch put up for review in D73962.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72154/new/

https://reviews.llvm.org/D72154





More information about the llvm-commits mailing list