[PATCH] D73959: [mlir][spirv] Add dialect-specific attribute for target environment

Lei Zhang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 4 05:37:46 PST 2020


antiagainst created this revision.
antiagainst added a reviewer: denis13.
Herald added subscribers: llvm-commits, Joonsoo, liufengdb, aartbik, lucyrfox, mgester, arpith-jacob, nicolasvasilache, shauheen, burmako, jpienaar, rriddle, mehdi_amini, jfb.
Herald added a reviewer: mravishankar.
Herald added a project: LLVM.

We were using normal dictionary attribute for target environment
specification. It becomes cumbersome with more and more fields.
This commit changes the modelling to a dialect-specific attribute,
where we can have control over its storage and assembly form.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D73959

Files:
  mlir/docs/Dialects/SPIR-V.md
  mlir/include/mlir/Dialect/SPIRV/SPIRVDialect.h
  mlir/include/mlir/Dialect/SPIRV/TargetAndABI.h
  mlir/include/mlir/Dialect/SPIRV/TargetAndABI.td
  mlir/lib/Conversion/LinalgToSPIRV/LinalgToSPIRV.cpp
  mlir/lib/Dialect/SPIRV/SPIRVDialect.cpp
  mlir/lib/Dialect/SPIRV/SPIRVLowering.cpp
  mlir/lib/Dialect/SPIRV/TargetAndABI.cpp
  mlir/test/Conversion/LinalgToSPIRV/linalg-to-spirv.mlir
  mlir/test/Dialect/SPIRV/target-and-abi.mlir
  mlir/test/Dialect/SPIRV/target-env.mlir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D73959.242307.patch
Type: text/x-patch
Size: 43095 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200204/7323446e/attachment.bin>


More information about the llvm-commits mailing list