[PATCH] D73793: Improve error message of FileCheck when stdin is empty

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 4 01:53:22 PST 2020


jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

This looks fine to me, although having looked at what other tools do, it might be better to create a `reportError` type of function that takes an input filename as an argument and does the conversion from '-' if needed. See for example llvm-readobj.cpp `reportWarning` etc. I'm happy either way, as a quick glance suggests this may not be straightforward here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73793/new/

https://reviews.llvm.org/D73793





More information about the llvm-commits mailing list