[PATCH] D73653: [MLIR] Fixes for shared library dependencies.
Stephen Neuendorffer via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Feb 3 22:34:32 PST 2020
stephenneuendorffer marked an inline comment as done.
stephenneuendorffer added inline comments.
================
Comment at: mlir/lib/Dialect/FxpMathOps/CMakeLists.txt:9
+
+ LINK_LIBS
+ MLIRQuantOps
----------------
mehdi_amini wrote:
> It seems we've been using `target_link_libraries` elsewhere but they are the same, can we align on one form for consistency?
I fixed these to use target_link_libraries instead of LINK_LIBS
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73653/new/
https://reviews.llvm.org/D73653
More information about the llvm-commits
mailing list