[PATCH] D73654: [MLIR] break cyclic dependency between VectorOps and Analysis

Mon Feb 3 20:21:19 PST 2020

mehdi_amini added a comment.

In D73654#1856279 <https://reviews.llvm.org/D73654#1856279>, @stephenneuendorffer wrote:

> In D73654#1856264 <https://reviews.llvm.org/D73654#1856264>, @mehdi_amini wrote:
>
> > @stephenneuendorffer do you have commit access or are you waiting for someone to land it for you?
>
>
> I have commit access, unfortunately, this conflicts with recent changes and I'm trying to figure out how to undo the damage.
>  I fear that after this lands, churn will continually break this unless there are nightly builds running with BUILD_SHARED_LIBS=ON.
>  I assume Google is running internal builds: Any chance that you can add a shared library build?

We don't integrate from upstream on every commits, we wouldn't catch breakages immediately. Also we don't use CMake in our internal build system (we use Bazel).

Ideally we should have a bot added to http://lab.llvm.org:8011 ; it is mostly a matter of someone plugging it there.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73654/new/

https://reviews.llvm.org/D73654