[PATCH] D73653: [MLIR] Fixes for shared library dependencies.

[Stephen Neuendorffer via Phabricator via llvm-commits]

stephenneuendorffer added a comment.

In D73653#1848667 <https://reviews.llvm.org/D73653#1848667>, @mehdi_amini wrote:

> > A separate issue is that in cmake, dependencies between static libraries
> >  are automatically included in dependencies. In the above example, if MLIBlib1
> >  depends on MLIRlib2, then it is sufficient to have only MLIRlib1 in the
> >  target_link_libraries. When compiling with shared libraries, it is necessary
> >  to have both MLIRlib1 and MLIRlib2 specified.
>
> I believe this is only an issue if the target is directly using symbols from MLIRlib2 though.
>  If it only needs symbols from MLIRLib1 then this shouldn't be an issue right?


Yes, I agree.  I've edited the comment to be clearer in this regard.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73653/new/

https://reviews.llvm.org/D73653