[PATCH] D73888: [yaml2obj][obj2yaml] - Simplify format of the SHT_LLVM_ADDRSIG section.

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/test/tools/llvm-readobj/ELF/addrsig.test:23
     Type: SHT_LLVM_ADDRSIG
-    Symbols:
-      - Name: foo
-      - Name: bar
+    Symbols: [ foo, bar ]
 Symbols:
----------------
grimar wrote:
> Thinking about his again, I wonder if we want the following output format:
> ```
> Symbols:
>   - foo
>   - bar
> ```
> 
> All what is needed is to stop using `YAMLFlowString` and use `StringRef`,
> so the change is trivial.
> That might produce a nicer (?) output when symbol names are long probably,
> though I am not sure we should care too much here and/or what is better.
Is there a test having a special symbol name (a metacharacter in YAML.)? e.g. `[` 

Just want to make sure they are properly quoted.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73888/new/

https://reviews.llvm.org/D73888