[PATCH] D72454: [AIX] Enable frame pointer for AIX and add related test suite

[Chris Bowler via Phabricator via llvm-commits]

cebowleratibm added a comment.

Only minor test questions / requests.  The change looks ok.  I think we should explain the stack adj differences with the XL compiler before committing, specifically: do we need to allocate the PSA for the current frame even if there are no calls?



================
Comment at: llvm/test/CodeGen/PowerPC/Frames-dyn-alloca.ll:79
+; PPC32-AIX-NEXT: stwux 4, 1, 3
+; PPC32-AIX-NEXT: addi 3, 1, 32
+; PPC32-AIX-NEXT: lwz 1, 0(1)
----------------
Why are we adding 32 to the r3 return reg?


================
Comment at: llvm/test/CodeGen/PowerPC/Frames-small.ll:74
+; PPC32-AIX-NOFP-LABEL: frame_small
+; PPC32-AIX-NOFP:      stwu 1, -416(1)
+; PPC32-AIX-NOFP-NEXT: addi 3, 1, 36
----------------
XL compiler stack bump was 448 for this case.  I suspect they are allocating 32 bytes for the min PSA even though there are no calls.


================
Comment at: llvm/test/CodeGen/PowerPC/aix-frames-stack-floor.ll:1
+; RUN: llc -verify-machineinstrs < %s -mcpu=pwr4 -mattr=-altivec \
+; RUN: -mtriple=powerpc-ibm-aix-xcoff | FileCheck %s -check-prefix=PPC32-NOFP
----------------
I like test consistency across the PPC subtargets.  I'd like to see Linux 32/64 as part of this test for consistency and documenting the behaviour differences of the PPC subtargets.  If it makes sense to have an AIX stack floor test, then it makes sense to have a Linux stack floor test, even if it's not part of the test suite yet.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72454/new/

https://reviews.llvm.org/D72454