[PATCH] D73609: Change to individual pretty printer classes, remove generic `make_printer`.
David Blaikie via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Feb 3 14:54:03 PST 2020
dblaikie added inline comments.
================
Comment at: llvm/utils/gdb-scripts/prettyprinters.py:322-325
try:
enum_type = gdb.lookup_type(info_name + '::MaskAndShiftConstants')
except gdb.error:
return (None, None)
----------------
I think I asked this elsewhere, but not sure there was an answer (apologies if I forgot - might be worth a comment) - what is this error case for? Are there types in LLVM that don't provide this expected nested type?
Might be nice if it could be removed & then wouldn't need the factory layer of indirection for PointerIntPair and PointerUnion below.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73609/new/
https://reviews.llvm.org/D73609
More information about the llvm-commits
mailing list