[PATCH] D73812: [CMake] Filter libc++abi and libunwind from runtimes build on Windows/MSVC

[Shoaib Meenai via Phabricator via llvm-commits]

smeenai accepted this revision.
smeenai added a comment.
This revision is now accepted and ready to land.

In that case, looks good with the condition changed to `MSVC`.



================
Comment at: llvm/runtimes/CMakeLists.txt:30-31
 foreach(proj ${LLVM_ENABLE_RUNTIMES})
+  # TODO: libunwind and libcxxabi don't currently build on Windows so filter them out.
+  if((WIN32 AND NOT MINGW) AND ("${proj}" MATCHES "libunwind|libcxxabi"))
+    continue()
----------------
I think `MSVC` is a better condition here than `WIN32 AND NOT MINGW`, since libunwind and libc++abi aren't compatible with the MSVC ABI.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73812/new/

https://reviews.llvm.org/D73812