[PATCH] D73142: Heat Coloring for CFGPrinter and CallPrinter
Kirill Naumov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Feb 3 14:29:02 PST 2020
knaumov updated this revision to Diff 242186.
knaumov marked 8 inline comments as done.
knaumov added a comment.
Addressed @davidxl and @sfertile comments.
Answering @davidxl 's comment on "The function entry count should have the information", line 73, HeatUtils.cpp:
This function counts the number of calls of one specific function by another specific function while Function.entryCount() returns number entries for this function.
Answering @davidxl 's comment on "for the program's max count, max function count, get it from ProfileSummaryInfo.", line 99, HeatUtils.cpp:
ProfileSummaryInfo doesn't contain info on the maximum frequency in the module, it needs to be calculated.
Updates:
- Ran clang-format through all the files
- Deleted some function which had no use (see hasProfiling function)
- Deleted const unsigned variables
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73142/new/
https://reviews.llvm.org/D73142
Files:
llvm/include/llvm/Analysis/CFGPrinter.h
llvm/include/llvm/Analysis/HeatUtils.h
llvm/lib/Analysis/CFGPrinter.cpp
llvm/lib/Analysis/CMakeLists.txt
llvm/lib/Analysis/CallPrinter.cpp
llvm/lib/Analysis/DomPrinter.cpp
llvm/lib/Analysis/HeatUtils.cpp
llvm/lib/Analysis/RegionPrinter.cpp
llvm/lib/Passes/PassRegistry.def
llvm/lib/Transforms/Scalar/NewGVN.cpp
llvm/test/Other/2007-06-05-PassID.ll
llvm/test/Other/cfg-printer-branch-weights-percent.ll
llvm/test/Other/cfg-printer-branch-weights.ll
polly/lib/Analysis/ScopGraphPrinter.cpp
polly/lib/Support/RegisterPasses.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D73142.242186.patch
Type: text/x-patch
Size: 67374 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200203/a2fe75e3/attachment-0001.bin>
More information about the llvm-commits
mailing list