[PATCH] D73555: [SVE] Fix bug in simplification of scalable vector instructions
Simon Pilgrim via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Feb 3 12:46:21 PST 2020
RKSimon added inline comments.
================
Comment at: llvm/lib/Analysis/ValueTracking.cpp:169
APInt &DemandedLHS, APInt &DemandedRHS) {
+ // The length of scalable vectors is unknown at compile time, thus we
+ // cannot check their values
----------------
ctetreau wrote:
> @RKSimon This is the new code added. It modifies your recent patch, so I figured you'd like to review it.
Would it be viable to set all DemandedLHS/DemandedRHS instead so we can still handle all element cases?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73555/new/
https://reviews.llvm.org/D73555
More information about the llvm-commits
mailing list