[PATCH] D73908: [ARM][VecReduce] Force expand vector_reduce_fmin

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 3 11:48:22 PST 2020


nikic accepted this revision.
nikic added a comment.
This revision is now accepted and ready to land.

LGTM. Thanks for catching the issue in widening as well.

As a side note, the current fmin/fmax expansion in ExpandReductions is not well-defined (it uses an ordered cmp + select expansion on the assumption that only fast fmin/fmax reductions may exist). But that's a separate and preexisting issue.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73908/new/

https://reviews.llvm.org/D73908





More information about the llvm-commits mailing list