[PATCH] D73894: [MLIR] Add mapping based on ValueRange to BlockAndValueMapper.

River Riddle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 3 09:47:25 PST 2020


rriddle requested changes to this revision.
rriddle added inline comments.
This revision now requires changes to proceed.


================
Comment at: mlir/include/mlir/IR/BlockAndValueMapping.h:35
   }
+  void map(ValueRange from, ValueRange to) {
+    for (auto pair : llvm::zip(from, to))
----------------
I would prefer that we use templates instead of specific classes. That would also remove the need for any additional includes, among other benefits.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73894/new/

https://reviews.llvm.org/D73894





More information about the llvm-commits mailing list