[PATCH] D73772: [DebugInfo][test] Adjust line table unit length to account for contents

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 3 08:59:24 PST 2020


jhenderson marked an inline comment as done.
jhenderson added inline comments.


================
Comment at: llvm/unittests/DebugInfo/DWARF/DwarfGenerator.cpp:178
   }
+  P.TotalLength += Contents.size();
   P.FormParams.Version = Version;
----------------
jhenderson wrote:
> Oops, this is incorrect. Contents is not a vector of bytes of data, but rather of `ValueAndLength` entries, which potentially represent different numbers of bytes. I'll post a fix.
> I'll post a fix.
See D73901.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73772/new/

https://reviews.llvm.org/D73772





More information about the llvm-commits mailing list