[PATCH] D73885: [Alignment][NFC] Use Align for getMemcpy/Memmove/Memset

Guillaume Chatelet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 3 07:43:41 PST 2020


gchatelet added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:4228
+            Chain, DL, DstAddr, Arg, SizeNode,
+            Align(Outs[i].Flags.getByValAlign()),
             /*isVol = */ false, /*AlwaysInline = */ false,
----------------
courbet wrote:
> `getByValAlign()` can return zero, can you add a comment ?
I've introduced `getNonZeroByValAlign()` which cannot return zero,
As a matter of fact `getByValAlign()` is now useless and deprecated.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73885/new/

https://reviews.llvm.org/D73885





More information about the llvm-commits mailing list