[PATCH] D73885: [Alignment][NFC] Use Align for getMemcpy/Memmove/Memset

[Clement Courbet via Phabricator via llvm-commits]

courbet added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:4228
+            Chain, DL, DstAddr, Arg, SizeNode,
+            Align(Outs[i].Flags.getByValAlign()),
             /*isVol = */ false, /*AlwaysInline = */ false,
----------------
`getByValAlign()` can return zero, can you add a comment ?


================
Comment at: llvm/lib/Target/AMDGPU/SIISelLowering.cpp:2867
+            DAG.getMemcpy(Chain, DL, DstAddr, Arg, SizeNode,
+                          Align(Outs[i].Flags.getByValAlign()),
+                          /*isVol = */ false, /*AlwaysInline = */ true,
----------------
ditto.


================
Comment at: llvm/lib/Target/Hexagon/HexagonISelLowering.cpp:171
+  return DAG.getMemcpy(
+      Chain, dl, Dst, Src, SizeNode, Align(Flags.getByValAlign()),
+      /*isVolatile=*/false, /*AlwaysInline=*/false,
----------------
ditto


================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:2143
     unsigned Size = Flags.getByValSize();
-    unsigned Align = Flags.getByValAlign();
+    Align Alignment(Flags.getByValAlign());
 
----------------
ditto


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73885/new/

https://reviews.llvm.org/D73885