[PATCH] D73803: [InstCombine] Add replaceOperand() helper

[Sanjay Patel via Phabricator via llvm-commits]

spatel accepted this revision.
spatel added a comment.

LGTM



================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineInternal.h:687
+  /// Replace operand of instruction and add old operand to the worklist.
+  Instruction *replaceOperand(Instruction &I, unsigned Operand, Value *V) {
+    Worklist.AddValueDeferred(I.getOperand(Operand));
----------------
IMO, slightly easier to read if we name the "Operand" parameter "OpNum" or "OperandIndex" or some variant of those.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73803/new/

https://reviews.llvm.org/D73803