[PATCH] D73309: [lsan] Factor pthread-specific assumptions out of thread tracking code

[Yvan Roux via llvm-commits]

Hi Petr,

when I ru it manually, the output of the test before commit 38fd180 is:
----->
Test alloc: 0xf4f03680
Value after LSan: 0xf4f03680

=================================================================
==904==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 1337 byte(s) in 1 object(s) allocated from:
    #0 0xb0188  (/home/yvan.roux/build/good.tmp+0xb0188)
    #1 0xe5570  (/home/yvan.roux/build/good.tmp+0xe5570)
    #2 0xf74ac8a8  (/lib/arm-linux-gnueabihf/libc.so.6+0x168a8)

Objects leaked above:
0xf4f03680 (1337 bytes)

SUMMARY: AddressSanitizer: 1337 byte(s) leaked in 1 allocation(s).
<-----
and I only got the first two line after (with sometimes the right
output if I run it several times)
----->
Test alloc: 0xf4f03680
Value after LSan: 0xf4f03680
<-----


On Thu, 30 Jan 2020 at 03:03, Petr Hosek <phosek at google.com> wrote:
>
> Hi Yvan,
>
> Would it be possible to get some more details, e.g. getting a full output from the test? I've tried reproducing this failure on other platforms but I'm not seeing the same issue and we don't have access to any armv7 boards.
>
> Thanks,
> Petr
>
> On Wed, Jan 29, 2020 at 7:05 AM Yvan Roux <yvan.roux at linaro.org> wrote:
>>
>> Hi Roland and Petr,
>>
>> One of the patches in this series broke armv7 full bot, we got some
>> issue on the bot and didn't have time to bisect and reproduce the
>> issue, but here are the last logs:
>>
>> http://lab.llvm.org:8011/builders/clang-cmake-armv7-full/builds/8982/steps/ninja%20check%202/logs/FAIL%3A%20LeakSanitizer-AddressSanitizer-armhf%3A%3Astale_stack_leak.cpp
>>
>> Thanks,
>> Yvan
>>
>> On Sat, 25 Jan 2020 at 02:03, Petr Hosek via Phabricator via
>> llvm-commits <llvm-commits at lists.llvm.org> wrote:
>> >
>> > This revision was automatically updated to reflect the committed changes.
>> > Closed by commit rG38fd1806a169: [lsan] Factor pthread-specific assumptions out of thread tracking code (authored by mcgrathr, committed by phosek).
>> >
>> > Repository:
>> >   rG LLVM Github Monorepo
>> >
>> > CHANGES SINCE LAST ACTION
>> >   https://reviews.llvm.org/D73309/new/
>> >
>> > https://reviews.llvm.org/D73309
>> >
>> > Files:
>> >   compiler-rt/lib/lsan/CMakeLists.txt
>> >   compiler-rt/lib/lsan/lsan.cpp
>> >   compiler-rt/lib/lsan/lsan.h
>> >   compiler-rt/lib/lsan/lsan_interceptors.cpp
>> >   compiler-rt/lib/lsan/lsan_posix.cpp
>> >   compiler-rt/lib/lsan/lsan_posix.h
>> >   compiler-rt/lib/lsan/lsan_thread.cpp
>> >   compiler-rt/lib/lsan/lsan_thread.h
>> >
>> > _______________________________________________
>> > llvm-commits mailing list
>> > llvm-commits at lists.llvm.org
>> > https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits