[PATCH] D73844: [X86] Update the haswell and broadwell scheduler information for gather instructions

Mon Feb 3 06:25:38 PST 2020

andreadb accepted this revision.
andreadb added a comment.
This revision is now accepted and ready to land.

In D73844#1854616 <https://reviews.llvm.org/D73844#1854616>, @RKSimon wrote:

> In D73844#1854361 <https://reviews.llvm.org/D73844#1854361>, @andreadb wrote:
>
> > Here is the idea: why don't we just add new writes for gather instructions (ideally a new write per each type of gather)?. I think that we shall consider this alternative (maybe in a follow up patch? I don't particularly mind..). Not sure if other people agree with this.
>
>
> Adding gather (and broadcast) schedule classes is on my backlog - as long as the InstRW entries are correct, I'll replace them when I get aroung to doing it. So, staying with InstRW for this patch is fine by me.

Sounds like a good plan to me.

I don't have other comments. Assuming that numbers are correct, the patch looks good to me.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73844/new/

https://reviews.llvm.org/D73844