[PATCH] D72475: [WIP] Build assume from call

Mon Feb 3 04:34:04 PST 2020

Tyker marked an inline comment as done.
Tyker added a comment.

In D72475#1853787 <https://reviews.llvm.org/D72475#1853787>, @jdoerfert wrote:

> In D72475#1853751 <https://reviews.llvm.org/D72475#1853751>, @fhahn wrote:
>
> > Is this approach documented somewhere in-tree? I think it would be good to document it, rather than just having a link to the mailing list.
>
>
> Lang Ref needs to be updated now. Agreed. @Tyker do you want to do that or should I?

this is needed. if you want i can do it.

================
Comment at: llvm/include/llvm/Transforms/Utils/KnowledgeRetention.h:9
+//
+// This file contain tools to preserve informations. They should be used before
+// performing a transformation moving and deleting instruction as those
----------------
jdoerfert wrote:
> fhahn wrote:
> > jdoerfert wrote:
> > > fhahn wrote:
> > > > I think it would be good to describe what kinds of information are preserved.
> > > That is always hard to keep in sync. I would prefer a generic file comment and alternatively more details on the `BuildAssumeFromInst` description below.
> > Sure, a reference to the langref or something like that is fine. But as it reads now it does not give any kind of indication of what this can/should be used for.
> The lang ref change was on my list anyway. Basically as part of the first in-tree use, which is the alignment assumption. We'll prioritize the lang ref patch now.
> 
> In addition we could add that some information to `BuildAssumeFromInst` that it retains `llvm::Attribute` information for now.
> In addition we could add that some information to BuildAssumeFromInst that it retains llvm::Attribute information for now.

this restriction should be lifted at some point.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72475/new/

https://reviews.llvm.org/D72475