[PATCH] D73795: [mlir] Drop customization hooks from StandardToLLVM conversion

Alex Zinenko via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 3 04:19:11 PST 2020


ftynse added a comment.

In D73795#1852802 <https://reviews.llvm.org/D73795#1852802>, @dcaballe wrote:

> Just wondering how this will impact the LLVM lowering customization scalability problem in general. By removing the hook for patterns, won't we go from an explosion of `populate*` functions to an explosion of LLVM lowering passes?


This looks orthogonal to me. This will not prevent the potential explosion of `populate*` functions, neither will the presence of the hooks since you'd need to create one composed "populate" function anyway.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73795/new/

https://reviews.llvm.org/D73795





More information about the llvm-commits mailing list