[PATCH] D73851: [ThinLTO] More efficient export computation (NFC)
Eugene Leviant via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Feb 3 02:45:43 PST 2020
evgeny777 added inline comments.
================
Comment at: llvm/lib/Transforms/IPO/FunctionImport.cpp:680
+ // there as to why.
+ auto *S = Index.findSummaryInModule(EI, ELI.first());
+ assert(S);
----------------
On the average this will iterate over N/2 summaries in EI.getSummaryList(). Can this be replaced with:
```
auto *S = DefinedGVSummaries[EI.getGUID()];
```
? Probably the assetion above can be removed after that.
================
Comment at: llvm/lib/Transforms/IPO/FunctionImport.cpp:691
+ NewExports.insert(VI);
+ }
+ } else {
----------------
nit: you don't need {} for if statement
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73851/new/
https://reviews.llvm.org/D73851
More information about the llvm-commits
mailing list