[PATCH] D73820: [llvm-strip][WebAssembly] Support strip flags

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 3 02:17:39 PST 2020


jhenderson added a comment.

I'll take a look at this in the coming days. Got a lot on my plate at the moment!



================
Comment at: llvm/tools/llvm-objcopy/wasm/WasmObjcopy.cpp:97
+      // Otherwise defer to RemovePred.
+      return RemovePred(Sec);
+    };
----------------
sbc100 wrote:
> Interesting technique of chaining the predicates together like this using lamda.    Might be a little too clever?   Do other object backends use this too?
This is how it is done in ELF objcopy, and I think maybe the others too.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73820/new/

https://reviews.llvm.org/D73820





More information about the llvm-commits mailing list