[PATCH] D73866: [RDA] getInstFromId: find instructions. NFC.

[Sam Parker via Phabricator via llvm-commits]

samparker added a comment.

This doesn't look safe to me. lookup will return a default constructed value if an existing object doesn't exist and I'm pretty sure this will be 0. This is also a perfectly reasonable number for InstId to be, therefore providing the wrong MI when an instruction has been inserted as the first instruction in the block, without RDA knowing about it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73866/new/

https://reviews.llvm.org/D73866