[PATCH] D73793: Improve error message of FileCheck when stdin is empty
George Rimar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Feb 3 01:59:16 PST 2020
grimar added a comment.
In D73793#1854135 <https://reviews.llvm.org/D73793#1854135>, @jhenderson wrote:
> I have a vague and probably unreasonable concern that changing from the beahviour for a filename "<stdin>" could cause somebody some confusion somewhere, since it's non-standard.
FWIW on windows file names seems can't contain "<" or ">" characters. On ubuntu it seems to be OK.
But my non-very-strong-but-still-feeling here is that your concern is valid.
> I do agree with changing the error message though (we do similar things already in other tools, IIRC).
Improving the error message sounds good to me too.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73793/new/
https://reviews.llvm.org/D73793
More information about the llvm-commits
mailing list