[PATCH] D73078: [VPlan] Use consecutive numbers to print VPValues instead of addresses.
Gil Rapaport via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Feb 3 01:41:22 PST 2020
gilr added a comment.
It would indeed be good to improve VPValue printing. Initially, there were only a handful of VPValues so those pointer-based IDs seemed sufficient.
Since VPValues are now both more common and optionally have an underlying IR value, retaining names from the underlying IR where available could go a long way w.r.t both readability and relating to the loop being vectorized; This would hopefully cover most VPValues.
BTW, VP basic blocks could also retain the name of the corresponding IR basic block.
It would also be good to distinguish between "pure" VPValues and VPValues wrapping unnamed IR values (can we somehow retain the latter's enumeration?)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73078/new/
https://reviews.llvm.org/D73078
More information about the llvm-commits
mailing list