[PATCH] D73864: [X86] FUCOMI/FCOMI instructions should Def FPSW not FPCW.

[Craig Topper via Phabricator via llvm-commits]

craig.topper created this revision.
craig.topper added reviewers: pengfei, RKSimon, spatel, LiuChen3.
Herald added a subscriber: hiraditya.
Herald added a project: LLVM.

These instructions can set the exception in FPSW. But I
don't think they can change FPCW. So this looks like a typo.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D73864

Files:
  llvm/lib/Target/X86/X86InstrFPStack.td


Index: llvm/lib/Target/X86/X86InstrFPStack.td
===================================================================
--- llvm/lib/Target/X86/X86InstrFPStack.td
+++ llvm/lib/Target/X86/X86InstrFPStack.td
@@ -645,7 +645,7 @@
 
 let SchedRW = [WriteFCom], mayRaiseFPException = 1 in {
 // CC = ST(0) cmp ST(i)
-let Defs = [EFLAGS, FPCW], Uses = [FPCW] in {
+let Defs = [EFLAGS, FPSW], Uses = [FPCW] in {
 def UCOM_FpIr32: FpI_<(outs), (ins RFP32:$lhs, RFP32:$rhs), CompareFP,
                   [(set EFLAGS, (X86any_fcmp RFP32:$lhs, RFP32:$rhs))]>,
                   Requires<[FPStackf32, HasCMov]>;


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D73864.241974.patch
Type: text/x-patch
Size: 596 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200203/63cbaa55/attachment.bin>