[PATCH] D72475: [WIP] Build assume from call

[Florian Hahn via Phabricator via llvm-commits]

fhahn added inline comments.


================
Comment at: llvm/include/llvm/Transforms/Utils/KnowledgeRetention.h:9
+//
+// This file contain tools to preserve informations. They should be used before
+// performing a transformation moving and deleting instruction as those
----------------
jdoerfert wrote:
> fhahn wrote:
> > I think it would be good to describe what kinds of information are preserved.
> That is always hard to keep in sync. I would prefer a generic file comment and alternatively more details on the `BuildAssumeFromInst` description below.
Sure, a reference to the langref or something like that is fine. But as it reads now it does not give any kind of indication of what this can/should be used for.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72475/new/

https://reviews.llvm.org/D72475