[PATCH] D73837: Add minimal test for the ThinLtoJIT example

Stefan Gränitz via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Feb 2 11:20:04 PST 2020


sgraenitz added inline comments.


================
Comment at: llvm/test/Examples/ThinLtoJIT/minimal.test:12
+# CHECK: Modules submitted asynchronously: {{[0-6]}}
+# CHECK: Modules submitted synchronously: {{[0-6]}}
----------------
aprantl wrote:
> sgraenitz wrote:
> > @aprantl Did you show me the regex matchers for lit check lines last year? I cannot find the documentation for it anymore. It would be nice to grab the actual numbers here and check that their sum is `6`. Is that possible? (In 99% of cases it will be `3` and `3`, but in the end it's a timing issue and I don't want to rely on it.)
> The general documentation is here: https://www.llvm.org/docs/CommandGuide/FileCheck.html
> 
> I remember there was discussion in https://reviews.llvm.org/D49084 to add a computation mechanism to FileCheck and apparently this went in:
> 
> https://www.llvm.org/docs/CommandGuide/FileCheck.html#filecheck-numeric-substitution-blocks
> 
> !
Thank you! That's exactly what I was looking for.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73837/new/

https://reviews.llvm.org/D73837





More information about the llvm-commits mailing list