[PATCH] D72475: [WIP] Build assume from call
Johannes Doerfert via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Feb 2 10:34:39 PST 2020
jdoerfert added a comment.
In D72475#1853681 <https://reviews.llvm.org/D72475#1853681>, @Tyker wrote:
> In D72475#1853612 <https://reviews.llvm.org/D72475#1853612>, @MaskRay wrote:
>
> > It'd be nice if the description of 8ebe001553d0c204cc41f3dbc595031828b1f140 <https://reviews.llvm.org/rG8ebe001553d0c204cc41f3dbc595031828b1f140> could mention what is different from previous attempts... Two previous reverts did not say why this patch was reverted.
> >
> > Also, you can strip `Subscribers:` and `Tags: #llvm` lines from the description. They are not useful. I am using this script:
> >
> > arcfilter () {
> > git log -1 --pretty=%B | awk '/Reviewers:|Subscribers:/{p=1} /Reviewed By:|Differential Revision:/{p=0} !p && !/^Summary:/' | git commit --amend -F -
> > }
> >
>
>
> sorry for all the commit and revert. some build bot have a compile error under gcc that I can't reproduce locally. so commits and reverts are kind of trial and error. if there is a better way do deal with this kind of issue please let me know.
> I will strip the auto-generated parts of the comments from phab. thanks for the script.
I usually ask on IRC if anyone knows / can reproduce the error.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72475/new/
https://reviews.llvm.org/D72475
More information about the llvm-commits
mailing list