[PATCH] D73194: [FPEnv][ARM] Add lowering of STRICT_FSETCC and STRICT_FSETCCS

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Feb 2 07:59:16 PST 2020


dmgreen accepted this revision.
dmgreen added a comment.
This revision is now accepted and ready to land.

OK. It looks like that is at least not going to be simple to sort out immediately.

In the meantime, not crashing is certainly better than crashing, and I think the rest of this code looks good. It's just the strict ordering that we are missing. Please see if you can follow up with either adding a chain or not using glue.

LGTM otherwise.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73194/new/

https://reviews.llvm.org/D73194





More information about the llvm-commits mailing list