[PATCH] D73831: AMDGPU/GFX10: Fix NSA reassign pass when operands are undef

Nicolai Hähnle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Feb 1 13:47:00 PST 2020


nhaehnle marked an inline comment as done.
nhaehnle added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/GCNNSAReassign.cpp:292
+        // range. Seed a reasonable index range if required.
+        if (!I)
+          MinInd = MaxInd = LIS->getInstructionIndex(*MI);
----------------
arsenm wrote:
> Treating a loop counter as a boolean is mildly unexpected. I would prefer to write this out as I == 0
Sure, I'll change that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73831/new/

https://reviews.llvm.org/D73831





More information about the llvm-commits mailing list