[PATCH] D73826: [mlir][Linalg][WIP][RFC] OpGen hooks

Nicolas Vasilache via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Feb 1 10:18:22 PST 2020


nicolasvasilache added a comment.

In D73826#1853198 <https://reviews.llvm.org/D73826#1853198>, @jpienaar wrote:

> The previous rev was reverted as during discussion this feature was seen as unclear if we wanted to support, was changing the functionality & contract of the tool. Opening a new rev while rolling in the previous change does not resolve that discussion.


No it does not and does not intend to resolve the discussion but to reopen it with a concrete use case.

This revision shows one possible implementation of "named" Linalg ops specified in a declarative fashion.
As often in that space, one has to try to build it to understand it, the 6 points in my commit message describe some of the tradeoffs involved.

A clear open problem is how to improve the core infra support to make it better, more natural and future proof.
The fact that this revision builds on previously reverted code is circumstantial, this was the simplest way to show people where Linalg intends to go.

I'll mark as WIP and RFC to make it clearer that this is not intended to land as is.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73826/new/

https://reviews.llvm.org/D73826





More information about the llvm-commits mailing list