[PATCH] D73831: AMDGPU/GFX10: Fix NSA reassign pass when operands are undef

[Matt Arsenault via Phabricator via llvm-commits]

arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.

LGTM with nit



================
Comment at: llvm/lib/Target/AMDGPU/GCNNSAReassign.cpp:292
+        // range. Seed a reasonable index range if required.
+        if (!I)
+          MinInd = MaxInd = LIS->getInstructionIndex(*MI);
----------------
Treating a loop counter as a boolean is mildly unexpected. I would prefer to write this out as I == 0


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73831/new/

https://reviews.llvm.org/D73831