[PATCH] D73809: eSupport] Don't modify the current EH context during stack unwinding

[Alexandre Ganea via Phabricator via llvm-commits]

aganea added inline comments.


================
Comment at: llvm/lib/Support/Windows/Signals.inc:234
   // flag set to indicate that there's less data.
   CONTEXT Context = *ContextOrig;
   Context.ContextFlags = CONTEXT_CONTROL | CONTEXT_INTEGER;
----------------
This part is duplicating the context.


================
Comment at: llvm/lib/Support/Windows/Signals.inc:311
 
   while (true) {
     if (!fStackWalk64(NativeMachineType, hProcess, hThread, &StackFrame,
----------------
This one is not (and is inherently corrected by your fix).

Ideally it'd be nice to factor out the stackwalk code, duplicated behavior always ends up leading to bad things :-)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73809/new/

https://reviews.llvm.org/D73809