[PATCH] D73635: [mlir][VectorOps] Add ShapeCastOp to the vector ops dialect.
River Riddle via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jan 31 21:01:06 PST 2020
rriddle marked an inline comment as done.
rriddle added inline comments.
================
Comment at: mlir/lib/Dialect/VectorOps/VectorOps.cpp:1574
+
+ParseResult parseShapeCastOp(OpAsmParser &parser, OperationState &result) {
+ OpAsmParser::OperandType source;
----------------
rriddle wrote:
> nit: Can you use the declarative assembly form now that it has landed? There isn't any docs yet(sorry, some stuff is still in-flight), but this one should be something like:
>
> let assemblyFormat = "$source attr-dict type($source) `to` type($result)";
We should be able to remove these now, right?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73635/new/
https://reviews.llvm.org/D73635
More information about the llvm-commits
mailing list