[PATCH] D73497: lld: Propeller framework part I
Han Shen via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jan 31 17:11:59 PST 2020
shenhan marked 2 inline comments as done.
shenhan added inline comments.
================
Comment at: lld/include/lld/Common/PropellerCommon.h:46
+ // Unique index number across all symbols that participate linking.
+ uint64_t Ordinal;
+ // For a function symbol, it's the full name. For a bb symbol this is only the
----------------
MaskRay wrote:
> Prefer lowerCased variable names.
I'll address this later, cause this changes almost every other file.
================
Comment at: lld/include/lld/Common/PropellerCommon.h:82
+ if (O->Size == 0) {
+ // Note if O's size is 0, we allow O on the end boundary. For example, if
+ // foo.BB.4 is at address 0x10. foo is [0x0, 0x10), we then assume foo
----------------
MaskRay wrote:
> Rationale? Do you have a concrete example this rule is needed?
Yeah, we see zero-sized basic block symbol at the end of a function.
Repository:
rLLD LLVM Linker
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73497/new/
https://reviews.llvm.org/D73497
More information about the llvm-commits
mailing list