[PATCH] D73600: [Matrix] Add remark propagation along the inlined-at chain.

[Adam Nemet via Phabricator via llvm-commits]

anemet added a comment.

On the description: I would first explain what you do and then how to do, i.e. have "To motivate" and the example before the paragprah "For a given function, we traverse".



================
Comment at: llvm/lib/Transforms/Scalar/LowerMatrixIntrinsics.cpp:960
 
+    /// Set of values to consider as matrix operations.
+    const SmallSetVector<Value *, 32> &ExprSet;
----------------
I am assuming these values that falls into a given DISubprogram?  More explanation would be good here and probably a bit more specific name than ExprSet.


================
Comment at: llvm/lib/Transforms/Scalar/LowerMatrixIntrinsics.cpp:1225
+    SmallVector<Value *, 4>
+    getExpressionLeaves(const SmallSetVector<Value *, 32> &Ops) {
       SmallVector<Value *, 4> Leaves;
----------------
Explain Ops in the comment.


================
Comment at: llvm/lib/Transforms/Scalar/LowerMatrixIntrinsics.cpp:1292
+      // to the containing function.
+      MapVector<DISubprogram *, SmallVector<Value *, 8>> Mapping;
+      for (auto &KV : Inst2ColumnMatrix) {
----------------
Mapping is usually not a good name ;)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73600/new/

https://reviews.llvm.org/D73600