[PATCH] D73816: [compiler-rt] implement sigaltstack interception
Evgenii Stepanov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jan 31 16:25:46 PST 2020
eugenis added a comment.
In D73816#1852789 <https://reviews.llvm.org/D73816#1852789>, @sugak wrote:
> I manually tested this on CentOS and would need guidance about the use of `SI_POSIX`, as well as how to make a unittest for this (if needed).
SI_POSIX seems alright. Please add a simple test under compiler-rt/test/msan - just call the function and check that accessing memory does not trigger msan.
================
Comment at: compiler-rt/lib/sanitizer_common/sanitizer_common_syscalls.inc:2901
+ if (ss != nullptr) {
+ POST_READ(ss, struct_stack_t_sz);
+ }
----------------
POST_READ is unnecessary here - it is mainly for the case when the read range is not known until the syscall returns.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73816/new/
https://reviews.llvm.org/D73816
More information about the llvm-commits
mailing list