[PATCH] D73471: Add tanh lowering from Standard dialect to NVVM and ROCDL.

[Nicolas Vasilache via Phabricator via llvm-commits]

nicolasvasilache added inline comments.
Herald added a subscriber: Joonsoo.


================
Comment at: mlir/test/Conversion/GPUToNVVM/gpu-to-nvvm.mlir:160
 gpu.module @test_module {
+  // CHECK: llvm.func @__nv_tanhf(!llvm.float) -> !llvm.float
+  // CHECK: llvm.func @__nv_tanh(!llvm.double) -> !llvm.double
----------------
@stella.stamenova is the determinism issue resolved by replacing all the new introduced `CHECK` by `CHECK-DAG` ?  

@rriddle @mehdi_amini this is the original root cause of the benefit twiddling revision.
I can't tell offhand whether all the pieces involved in rewriting and lowering to LLVM are supposed to be deterministic across targets?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73471/new/

https://reviews.llvm.org/D73471